Skip to content

[rllib] Re-enable all RLlib doctests #58974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonsays1980 merged 6 commits into from
Dec 1, 2025
Merged

[rllib] Re-enable all RLlib doctests #58974

simonsays1980 merged 6 commits into from
Dec 1, 2025
+27 −41

Conversation

@pseudo-rnd-thoughts
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts commented Nov 25, 2025

Description

The RLlib team is working on improving our testing position.
Currently several files are excluded in our doctest. This PR moves to add testing for the whole project

Mark Towers added 2 commits November 25, 2025 15:46
[rllib] Re-enable all RLlib doctests
480cf7d 
Signed-off-by: Mark Towers <mark@anyscale.com>
Remove the deprecated files
94d3fed 
Signed-off-by: Mark Towers <mark@anyscale.com>
@pseudo-rnd-thoughts
Copy link
Member Author

pseudo-rnd-thoughts commented Nov 26, 2025 •
edited
Loading

Actually failing doctests

=========================== short test summary info ============================
--
FAILED rllib/algorithms/algorithm_config.py::rllib.algorithms.algorithm_config.AlgorithmConfig
FAILED rllib/algorithms/algorithm_config.py::rllib.algorithms.algorithm_config.DifferentiableAlgorithmConfig
FAILED rllib/algorithms/dreamerv3/dreamerv3.py::rllib.algorithms.dreamerv3.dreamerv3.DreamerV3Config
FAILED rllib/algorithms/algorithm_config.py::rllib.algorithms.algorithm_config.AlgorithmConfig
FAILED rllib/algorithms/algorithm_config.py::rllib.algorithms.algorithm_config.DifferentiableAlgorithmConfig
FAILED rllib/algorithms/dreamerv3/dreamerv3.py::rllib.algorithms.dreamerv3.dreamerv3.DreamerV3Config
FAILED rllib/core/models/base.py::rllib.core.models.base.Encoder
FAILED rllib/core/models/base.py::rllib.core.models.base.Model
FAILED rllib/core/models/base.py::rllib.core.models.base.Encoder
FAILED rllib/core/models/base.py::rllib.core.models.base.Model
FAILED rllib/utils/actor_manager.py::rllib.utils.actor_manager.FaultTolerantActorManager
FAILED rllib/utils/actor_manager.py::rllib.utils.actor_manager.FaultTolerantActorManager

Mark Towers and others added 3 commits November 26, 2025 11:10
Resolve doctest issues
39f7248 
Signed-off-by: Mark Towers <mark@anyscale.com>
@pseudo-rnd-thoughts
Merge branch 'master' into fix-doctest
9f35734 
Signed-off-by: Mark Towers <mark.m.towers@gmail.com>
Update doctest
a0eabac 
Signed-off-by: Mark Towers <mark@anyscale.com>
@pseudo-rnd-thoughts pseudo-rnd-thoughts added the rllib RLlib related issues label Nov 26, 2025
@pseudo-rnd-thoughts
Merge branch 'master' into fix-doctest
51f60fc 
Signed-off-by: Mark Towers <mark.m.towers@gmail.com>
@pseudo-rnd-thoughts pseudo-rnd-thoughts marked this pull request as ready for review November 27, 2025 17:15
@pseudo-rnd-thoughts pseudo-rnd-thoughts requested a review from a team as a code owner November 27, 2025 17:15
@pseudo-rnd-thoughts pseudo-rnd-thoughts added the go add ONLY when ready to merge, run all tests label Nov 28, 2025
simonsays1980
simonsays1980 approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvements @pseudo-rnd-thoughts !

rllib/algorithms/algorithm_config.py
differentiable_learner_configs=[
DifferentiableLearnerConfig(
DifferentiableTorchLearner,
TorchDifferentiableLearner,
Copy link
Contributor

@simonsays1980 simonsays1980 Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, was this an error induced during test construction?

Copy link
Member Author

@pseudo-rnd-thoughts pseudo-rnd-thoughts Dec 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the test was disabled therefore no one noticed the wrong name ordering

Copy link
Contributor

@simonsays1980 simonsays1980 Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@simonsays1980 simonsays1980 merged commit 305969b into ray-project:master Dec 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

Assignees

No one assigned

Labels

go add ONLY when ready to merge, run all tests rllib RLlib related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pseudo-rnd-thoughts @simonsays1980