[ci] Upgrade pydoclint to 0.8.3 and revert pydoclint baseline workaround
#59004
Conversation
thomasdesr
force-pushed
the
thomas/revert-pydoclint-baseline-workaround
branch
from
329671d to
e5e5fc5
Compare
Remove the dual local/CI hook configuration for pydoclint and simplify back to a single hook. The workaround was needed due to a bug, but this is now fixed in pydoclint 0.8.3. - Upgrade pydoclint from 0.8.1 to 0.8.3 - Remove separate pydoclint-local and pydoclint-ci hooks - Simplify CI lint script to use standard pre-commit run Signed-off-by: Thomas Desrosiers <thomas@anyscale.com>
thomasdesr
force-pushed
the
thomas/revert-pydoclint-baseline-workaround
branch
from
e5e5fc5 to
eaf19fb
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully upgrades pydoclint to version 0.8.3 and simplifies the pre-commit hook configuration by removing the dual pydoclint-local and pydoclint-ci hooks. This change addresses the workaround previously needed due to pydoclint's behavior with partial file inputs. The new setup streamlines the linting process by consolidating to a single pydoclint hook that runs on pre-commit and pre-push stages. The removal of the git diff check in ci/lint/lint.sh aligns with the auto-regenerate-baseline=False setting, indicating a shift towards manual management of the pydoclint-baseline.txt file. While this simplifies the configuration, it's important to ensure the new baseline management workflow is clear to maintain docstring quality effectively.
2 participants
Description
Remove the dual local/CI hook configuration for pydoclint and simplify back to a single hook. The workaround was needed due to jsh9/pydoclint#274, but this was fixed in pydoclint
0.8.3🎉0.8.1to0.8.3pydoclint-localandpydoclint-cihooksRelated issues
Additional information