[core] Test for more browser-specific headers in dashboard browser rejection logic #59042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richo Healey <richo@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the detection of browser-based requests by adding more headers to the denylist, including Referer, Origin, and CORS-related headers. The changes are accompanied by a comprehensive set of new test cases that cover various browsers and scenarios, which is great. My feedback focuses on improving the maintainability and readability of both the implementation and the new tests.
edoakes
changed the title
edoakes
approved these changes
Nov 27, 2025
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Nov 27, 2025
…jection logic (ray-project#59042) ## Description Adds more headers to the denylist for recognising browser requests and denying them ## Related issues Supercedes ray-project#59040 Signed-off-by: Richo Healey <richo@anyscale.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Nov 27, 2025
…jection logic (ray-project#59042) ## Description Adds more headers to the denylist for recognising browser requests and denying them ## Related issues Supercedes ray-project#59040 Signed-off-by: Richo Healey <richo@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
This was referenced Nov 27, 2025
edoakes
added a commit
that referenced
this pull request
Nov 27, 2025
Cherry pick: - #59042 Signed-off-by: Richo Healey <richo@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: richo-anyscale <richo@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds more headers to the denylist for recognising browser requests and denying them
Related issues
Supercedes #59040