[docs/data] Add download to key user journeys in documentation
#59417
Conversation
richardliaw
added
docs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces documentation for the download expression in Ray Data, which is a valuable addition. The examples are clear and helpful for users looking to download data from URIs within their datasets. I've identified a couple of minor areas for improvement in the code examples to enhance clarity by removing unused imports. The other changes in this PR, which correct file paths, are accurate and necessary.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| NUM_GPU_NODES = 8 | ||
| INPUT_PATH = "s3://anonymous@ray-example-data/imagenet/metadata_file" | ||
| INPUT_PATH = "s3://anonymous@ray-example-data/imagenet/metadata_file.parquet" |
There was a problem hiding this comment.
Bug: Inconsistent path update between benchmark comparison scripts
The INPUT_PATH in ray_data_main.py was updated to include .parquet, but the companion benchmark file daft_main.py in the same directory still uses the old path s3://anonymous@ray-example-data/imagenet/metadata_file without the extension. These two files are meant to compare Ray Data vs Daft performance on the same image classification workload, so they need to read from the same data path. This inconsistency will cause either one benchmark to fail (if only one path exists) or the benchmarks to read from different datasets, making comparisons invalid.
…-project#59417) Shows users how to use `download` to download from URI tables. --------- Signed-off-by: Richard Liaw <rliaw@berkeley.edu> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: kriyanshii <kriyanshishah06@gmail.com>
…-project#59417) Shows users how to use `download` to download from URI tables. --------- Signed-off-by: Richard Liaw <rliaw@berkeley.edu> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2 participants
Shows users how to use
downloadto download from URI tables.