Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cloudpickle #7406

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Conversation

suquark
Copy link
Member

@suquark suquark commented Mar 3, 2020

Why are these changes needed?

There has been a lot of changes going on the upstream (including a lot of bug fix), especially the one that drops python2 support. This PR will shorten the gap between the upstream version.

Related issue number

Checks

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@suquark
Copy link
Member Author

suquark commented Mar 3, 2020

let's see if we can pass all tests

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22635/
Test FAILed.

@suquark suquark changed the title [WIP] Update cloudpickle Update cloudpickle Mar 3, 2020
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22636/
Test FAILed.

@pcmoritz
Copy link
Contributor

pcmoritz commented Mar 3, 2020

We should also update cloudpickle_fast.py :)

@pcmoritz
Copy link
Contributor

pcmoritz commented Mar 3, 2020

Ooop, you already did, nice!

@pcmoritz
Copy link
Contributor

pcmoritz commented Mar 3, 2020

Benchmark:

single client put gigabytes per second 10.84 +- 8.14

@pcmoritz pcmoritz merged commit f6883bf into ray-project:master Mar 3, 2020
pcmoritz added a commit that referenced this pull request Mar 4, 2020
pcmoritz added a commit that referenced this pull request Mar 4, 2020
ffbin pushed a commit to alipay/ant-ray that referenced this pull request Mar 20, 2020
ffbin pushed a commit to alipay/ant-ray that referenced this pull request Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants