Fix CI: drop EOL Python 3.9 and update GitHub Actions#464
Fix CI: drop EOL Python 3.9 and update GitHub Actions#464rexminnis wants to merge 12 commits intoray-project:masterfrom
Conversation
|
we should do this as part of the spark 4.x support, otherwise the new tf will break older spark which required numpy 1.2x |
2. <2.16 — stays on Keras 2, which the RayDP TF estimator requires 3. >=2.13.1 — supports Python 3.10/3.11
|
Thanks for the review @pang-wu. I want to clarify — this PR doesn't upgrade TensorFlow or numpy. It actually pins them conservatively to protect older Spark:
The core issue is that CI is broken on master right now —
All 13 matrix jobs pass (Spark 3.3.2/3.4.0/3.5.0 × Ray 2.37/2.40/2.50). Nothing here conflicts with or duplicates the Spark 4.x work. |
|
master is still working -- I just retrigger another job in a PR i file yesterday and it pull python 3.9: https://github.com/ray-project/raydp/actions/runs/22073389233/job/63950790956?pr=462 Another note -- we shouldn't deprecate Python 3.9 in CI until we have to for raydp 1.6.x. As they are built with that version, it is a guardrail to make sure there is not regression. |
|
You're right — I can see Python 3.9 setup succeeded on your run. The failure I hit on PR #463 ( Separately, I noticed PR #462 rewrites |
Summary
actions/setup-python@v2.3.4fails withcandidates is not iterablebecause Python 3.9 was removed fromubuntu-latestrunners (EOL since Oct 2025)actions/checkout(v2 → v4),actions/setup-python(v2 → v5),actions/cache(v2 → v4)numpy<1.24,pydantic<2.0,click<8.3.0)that were only needed for Python 3.9
==2.13.1→>=2.16.1,<2.19) for Python 3.11compatibility
raydp.yml(PR CI) andray_nightly_test.yml(nightly)Test plan