Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: pull out home page files to different file #229

Merged
merged 3 commits into from
Aug 19, 2022
Merged

refactor: pull out home page files to different file #229

merged 3 commits into from
Aug 19, 2022

Conversation

shrivatsabhat
Copy link
Collaborator

@shrivatsabhat shrivatsabhat commented Aug 19, 2022 •
edited
Loading

Description

  • home page refactor file structure

Type of change

  • New feature (non-breaking change which adds functionality)
  • Refactor ( rewrite or restructure code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Data Results

  • none

Additional Info

  • none

@vercel
Copy link

vercel bot commented Aug 19, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nexus-explorer-next ✅ Ready (Inspect) Visit Preview Aug 19, 2022 at 2:39PM (UTC)

@shrivatsabhat shrivatsabhat self-assigned this Aug 19, 2022
@shrivatsabhat shrivatsabhat changed the title refactor: pull out home page refactor: pull out home page files to different file Aug 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022 •
edited
Loading

Messages
📖 Changed Files in this PR:
  1. public/favicon.ico
  2. src/components/Header/PageHeader/PageHeader.jsx
  3. src/components/Panel1/Panel1.jsx
  4. src/components/Panel2/Panel2.jsx
  5. src/pages/index.js

Generated by 🚫 dangerJS against 2ee7a45

@github-actions github-actions bot added the chore chore related changes label Aug 19, 2022
@shrivatsabhat shrivatsabhat linked an issue Aug 19, 2022 that may be closed by this pull request
refactor the file systems #65
Closed
@rayanfer32
Copy link
Owner

For some reason the SSG is not working , its showing the shimmers on all the cards

@shrivatsabhat
Copy link
Collaborator Author

For some reason the SSG is not working , its showing the shimmers on all the cards

okay let me look into that

rayanfer32
rayanfer32 approved these changes Aug 19, 2022
View reviewed changes
Copy link
Owner

@rayanfer32 rayanfer32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shrivatsabhat shrivatsabhat merged commit 7fbf081 into develop Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayanfer32 rayanfer32 rayanfer32 approved these changes

Assignees

@shrivatsabhat shrivatsabhat

Labels
chore chore related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor the file systems
2 participants
@shrivatsabhat @rayanfer32