Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compact card text overlap on image #231

Merged
merged 1 commit into from
Aug 24, 2022
Merged

fix: compact card text overlap on image #231

merged 1 commit into from
Aug 24, 2022

Conversation

shrivatsabhat
Copy link
Collaborator

@shrivatsabhat shrivatsabhat commented Aug 23, 2022 •
edited
Loading

Description

  • compact card text is overlap with the card icon in the metric page

Type of change

  • New feature (non-breaking change which adds functionality)
  • Refactor ( rewrite or restructure code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Data Results

  • none

Additional Info

  • none

@vercel
Copy link

vercel bot commented Aug 23, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nexus-explorer-next ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 4:35PM (UTC)

@shrivatsabhat shrivatsabhat self-assigned this Aug 23, 2022
@github-actions github-actions bot added the bug label Aug 23, 2022
@github-actions
Copy link
Contributor

Messages
📖

Changed Files in this PR:

  1. src/components/common/NE_Card/NE_CompactCard/CompactCard.module.scss

Generated by 🚫 dangerJS against 472cefc

rayanfer32
rayanfer32 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Owner

@rayanfer32 rayanfer32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a final solution , but will approve it for now

@shrivatsabhat
Copy link
Collaborator Author

Not a final solution , but will approve it for now

Okay, We may require new design of we want to change major things

@shrivatsabhat shrivatsabhat merged commit ff40493 into develop Aug 24, 2022
@shrivatsabhat shrivatsabhat deleted the fix/compact-card-text-overflow branch March 29, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayanfer32 rayanfer32 rayanfer32 approved these changes

Assignees

@shrivatsabhat shrivatsabhat

Labels
bug
Projects
Nexus Explorer
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrivatsabhat @rayanfer32