Skip to content
This repository has been archived by the owner on May 22, 2023. It is now read-only.

feat: add react carousal for ads #47

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Conversation

rayanfer32
Copy link
Owner

@rayanfer32 rayanfer32 commented Jul 30, 2022

Description

Type of change

  • New feature (non-breaking change which adds functionality)
  • Refactor ( rewrite or restructure code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Data Results

  • none

Additional Info

  • none

@vercel
Copy link

vercel bot commented Jul 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nexus-market-cap ❌ Failed (Inspect) Jul 30, 2022 at 9:45AM (UTC)

@github-actions github-actions bot added chore feat New feature or request labels Jul 30, 2022
@github-actions
Copy link

Messages
📖 Changed Files in this PR:
  1. package.json
  2. src/components/Advertisement/Advertisement.module.scss
  3. src/components/Advertisement/Advertisement.tsx
  4. yarn.lock
📖 Please assign someone to merge this PR, and optionally include people who should review.

Generated by 🚫 dangerJS against 8b25b06

@rayanfer32
Copy link
Owner Author

@shrivatsabhat Need you help on this to fix the build issue with carousel type

No overload matches this call.
  Overload 1 of 2, '(props: ReactElasticCarouselProps | Readonly<ReactElasticCarouselProps>): ReactElasticCarousel', gave the following error.
    Type '{ children: Element[]; itemPadding: number[]; renderArrow: ({ type, onClick, isEdge }: RenderArrowProps) => Element; breakPoints: ({ width: number; itemsToShow: number; itemsToScroll?: undefined; pagination?: undefined; } | { ...; } | { ...; })[]; enableAutoPlay: true; autoPlaySpeed: number; itemsToShow: number; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<ReactElasticCarousel> & Readonly<ReactElasticCarouselProps>'.
      Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<ReactElasticCarousel> & Readonly<ReactElasticCarouselProps>'.
  Overload 2 of 2, '(props: ReactElasticCarouselProps, context: any): ReactElasticCarousel', gave the following error.
    Type '{ children: Element[]; itemPadding: number[]; renderArrow: ({ type, onClick, isEdge }: RenderArrowProps) => Element; breakPoints: ({ width: number; itemsToShow: number; itemsToScroll?: undefined; pagination?: undefined; } | { ...; } | { ...; })[]; enableAutoPlay: true; autoPlaySpeed: number; itemsToShow: number; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<ReactElasticCarousel> & Readonly<ReactElasticCarouselProps>'.
      Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<ReactElasticCarousel> & Readonly<ReactElasticCarouselProps>'.```

@shrivatsabhat shrivatsabhat linked an issue Jul 30, 2022 that may be closed by this pull request
@shrivatsabhat shrivatsabhat marked this pull request as draft August 9, 2022 18:59
@shrivatsabhat shrivatsabhat added the do not merge PR not to be merged to develop/main label Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore do not merge PR not to be merged to develop/main feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousal for Ads
2 participants