This repository has been archived by the owner on May 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add react carousal for ads #47
Draft
rayanfer32
wants to merge
2
commits into
develop
Choose a base branch
from
feat/react-carousal
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shrivatsabhat
approved these changes
Jul 30, 2022
@shrivatsabhat Need you help on this to fix the build issue with carousel type No overload matches this call.
Overload 1 of 2, '(props: ReactElasticCarouselProps | Readonly<ReactElasticCarouselProps>): ReactElasticCarousel', gave the following error.
Type '{ children: Element[]; itemPadding: number[]; renderArrow: ({ type, onClick, isEdge }: RenderArrowProps) => Element; breakPoints: ({ width: number; itemsToShow: number; itemsToScroll?: undefined; pagination?: undefined; } | { ...; } | { ...; })[]; enableAutoPlay: true; autoPlaySpeed: number; itemsToShow: number; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<ReactElasticCarousel> & Readonly<ReactElasticCarouselProps>'.
Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<ReactElasticCarousel> & Readonly<ReactElasticCarouselProps>'.
Overload 2 of 2, '(props: ReactElasticCarouselProps, context: any): ReactElasticCarousel', gave the following error.
Type '{ children: Element[]; itemPadding: number[]; renderArrow: ({ type, onClick, isEdge }: RenderArrowProps) => Element; breakPoints: ({ width: number; itemsToShow: number; itemsToScroll?: undefined; pagination?: undefined; } | { ...; } | { ...; })[]; enableAutoPlay: true; autoPlaySpeed: number; itemsToShow: number; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<ReactElasticCarousel> & Readonly<ReactElasticCarouselProps>'.
Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<ReactElasticCarousel> & Readonly<ReactElasticCarouselProps>'.``` |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist:
Data Results
Additional Info