fix(brokerage): replace use of pickle by dill

pyproject.toml

@@ -29,6 +29,7 @@ GitPython = "^3.1.27"
 pyadl = "^0.1"
 pandas = "^1.4.2"
 db-dtypes = "^1.0.1"
+dill = "^0.3.4"
 
 [tool.poetry.dev-dependencies]
 black = {version = "^22.3", allow-prereleases = true}

run.py

@@ -96,7 +96,7 @@ class FuzzingStrategyConfig:
     )
 
     # P(generating a statement at step t + 1 | a statement was generated at step t)
-    p_statement: float = 0.997
+    p_statement: float = 0.995
 
     # Number of optimiser fuzzing iterations
     optimiser_fuzzing_iterations: int = 20

src/__init__.py

@@ -1,7 +1,5 @@
 import hashlib
 import inspect
-import pickle
-import time
 from abc import ABC
 from dataclasses import field
 from dataclasses import fields
@@ -10,6 +8,7 @@
 from typing import TYPE_CHECKING
 from typing import TypeVar
 
+import dill
 from typing_extensions import Self
 
 
@@ -64,7 +63,7 @@ def __eq__(self, other) -> bool:
     def __hash__(self) -> int:
         return int(
             hashlib.sha224(
-                pickle.dumps(
+                dill.dumps(
                     tuple([hash(getattr(self, attr)) for attr in self.members()])
                 )
             ).hexdigest(),

src/fuzzing_server.py

@@ -148,8 +148,8 @@ def start(self):
                         thread_pool_executor.submit(
                             BQ_insert_new_shader, shader, self.generator_id
                         )
-                if paused:
-                    Monitor(self.config).info(event=Event.PAUSED)
+            if paused:
+                Monitor(self.config).info(event=Event.PAUSED)
 
             if random.SystemRandom().random() <= self.config.strategy.mutation_rate:
                 old_strategy = copy.deepcopy(self.config.strategy)

src/optimiser_fuzzer.py

@@ -8,7 +8,6 @@
 if TYPE_CHECKING:
     from src.fuzzing_server import SPIRVShader
 from src.monitor import Event, Monitor
-from src.shader_utils import validate_spv_file
 
 SPIRV_OPTIMISER_FLAGS = [
     "--amd-ext-to-khr",

src/shader_brokerage.py

@@ -1,6 +1,7 @@
-import pickle
 from typing import TYPE_CHECKING
 
+import dill
+
 from src.execution_platform import ExecutionPlatform
 from src.utils import get_spirvsmith_version
 
@@ -21,15 +22,15 @@
 
 
 def GCS_upload_shader(shader: "SPIRVShader") -> None:
-    pickled_shader: bytes = pickle.dumps(shader, protocol=pickle.HIGHEST_PROTOCOL)
+    pickled_shader: bytes = dill.dumps(shader, protocol=dill.HIGHEST_PROTOCOL)
     blob = BUCKET.blob(f"{shader.id}.pkl")
     blob.upload_from_string(pickled_shader)
 
 
 def GCS_download_shader(shader_id: str) -> "SPIRVShader":
     blob = BUCKET.blob(f"{shader_id}.pkl")
     pickled_shader: bytes = blob.download_as_bytes()
-    return pickle.loads(pickled_shader)
+    return dill.loads(pickled_shader)
 
 
 def BQ_insert_new_shader(
@@ -39,7 +40,7 @@ def BQ_insert_new_shader(
         INSERT INTO `spirvsmith.spirv.shader_data`
         VALUES (
             "{shader.id}",
-            {"1" if high_priority else "0"},
+            {1 if high_priority else 0},
             "{generator_id}",
             "{shader.context.config.misc.version}",
             {len(shader.context.get_storage_buffers())},
@@ -50,7 +51,7 @@ def BQ_insert_new_shader(
             NULL,
             NULL,
             NULL,
-            AUTO()
+            CURRENT_TIMESTAMP()
         )
     """
     BQ_CLIENT.query(insert_query).result()
@@ -77,7 +78,7 @@ def BQ_update_shader_with_buffer_dumps(
         "{execution_platform.get_active_hardware().hardware_model}",
         "{execution_platform.get_active_hardware().driver_version}",
         "{execution_platform.vulkan_backend.value}",
-        "AUTO",
+        CURRENT_TIMESTAMP(),
     )
     """
     delete_query = f"""

src/shader_utils.py

@@ -384,7 +384,7 @@ def create_amber_file(shader: SPIRVShader, filename: str) -> None:
         fw.write("#!amber\n")
         fw.write(f"SHADER compute {'shader'} SPIRV-ASM TARGET_ENV spv1.3\n")
         with tempfile.NamedTemporaryFile(suffix=".spasm") as fr:
-            shader.generate_assembly_file(filename=fr.name)
+            shader.generate_assembly_file(fr.name)
             lines = fr.readlines()
             for line in lines:
                 fw.write(line.decode("utf-8"))