Update key value extension to get the json from remote URL #12187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raycastbot
added
extension fix / improvement
NirLevy98
force-pushed
the
update-key-value-to-use-remote-url
branch
from
cd649b2 to
6708643
Compare
NirLevy98
changed the title
NirLevy98
force-pushed
the
update-key-value-to-use-remote-url
branch
2 times, most recently
from
87d8407 to
12db2d4
Compare
NirLevy98
force-pushed
the
update-key-value-to-use-remote-url
branch
from
12db2d4 to
fd9dff0
Compare
raycastbot
added
the
OP is contributor
|
Thank you for your contribution! 🎉 🔔 @NirLevy98 @gkpln3 you might want to have a look. |
|
Lgtm |
Comment on lines
+39
to
+59
| "name": "jsonURLPath", | ||
| "description": "URL path to a json file with key value pairs", | ||
| "type": "textfield", | ||
| "required": true, | ||
| "title": "Key Value Json URL" | ||
| }, | ||
| { | ||
| "name": "jsonKeyForKey", | ||
| "description": "Key name to search for", | ||
| "type": "textfield", | ||
| "required": true, | ||
| "title": "Key" | ||
| }, | ||
| { | ||
| "name": "jsonKeyForValue", | ||
| "description": "Key name to get the value from", | ||
| "type": "textfield", | ||
| "required": true, | ||
| "title": "Value" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Should the new preferences be required?
There was a problem hiding this comment.
It's should be required only under the reload command
pernielsentikaer
approved these changes
May 6, 2024
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the key-value extension to load the new key value from remote url
Screencast
Screen.Recording.2024-05-05.at.13.53.12.mov
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder