Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom-folder extension #13791

Merged
merged 8 commits into from
Aug 6, 2024
Merged

Conversation

Ph-lo
Copy link
Contributor

@Ph-lo Ph-lo commented Jul 31, 2024

Description

Create custom MacOS folder images from png.

Screencast

custom-folder-1
custom-folder-2

Checklist

- chore: package.json
- chore: package.json categories
- chore: package.json owner
- chore: organization handle set in package.json
- fix: result view file name
- feat: initial commit
@raycastbot raycastbot added the new extension Label for PRs with new extensions label Jul 31, 2024
@raycastbot
Copy link
Collaborator

Congratulations on your new Raycast extension! 🚀

You can expect an initial review within five business days.

Once the PR is approved and merged, the extension will be available on our Store.

@pernielsentikaer pernielsentikaer self-assigned this Aug 2, 2024
@pernielsentikaer
Copy link
Collaborator

Hi 👋

Thanks for your contribution 💪

I have now tested your extension, and I have some feedback ready for you:

  • Does it only work with some images? I tried a few times with different images and always getting:

custom-folder 2024-08-02 at 11 46 18

  • Could you check the CI errors

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@Ph-lo
Copy link
Contributor Author

Ph-lo commented Aug 2, 2024

Hi @pernielsentikaer, thank you for the quick review.
Would you be able to share one of the images you used for your test ?

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I tried with this image and a lot others 🙂

109-1090674_php-logo-png-php-logo-png-white

@Ph-lo
Copy link
Contributor Author

Ph-lo commented Aug 5, 2024

Thanks!
It turns out that it's working as expected. As of now, it only works with PNG images that have a transparent background, which can be seen as simple masking. The behavior you're expecting should be ready in the next version 🙂.

@pernielsentikaer
Copy link
Collaborator

Can you upload an image so I can test it 🙂

@Ph-lo
Copy link
Contributor Author

Ph-lo commented Aug 5, 2024

Of course, here as an example
php_logo
You could also test with any png from www.freepng.fr

- Merge pull request raycast#1 from Ph-lo/feat-image-shades
- feat: image shades option
- feat(wip): image shades
@Ph-lo
Copy link
Contributor Author

Ph-lo commented Aug 5, 2024

I ended up adding the feature as an option in the creation form, so the image on the folder can either be a filled mask or shaded tones.

@pernielsentikaer
Copy link
Collaborator

Let's go 🔥

@raycastbot raycastbot merged commit ea85a68 into raycast:main Aug 6, 2024
2 checks passed
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Published to the Raycast Store:
https://raycast.com/phlo/custom-folder

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@Ph-lo).
Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

@Ph-lo Ph-lo deleted the ext/custom-folder branch August 25, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants