Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time-converter extension #16183

Merged
merged 7 commits into from
Jan 19, 2025
Merged

Conversation

alexj
Copy link
Contributor

@alexj alexj commented Jan 5, 2025

Description

Screencast

Checklist

- Merge pull request raycast#1 from alexj/Retrying
- Ready to publish
- Fully working and passing the lint tests
- Readded typescript checking for ESLint
- Tweaks to fix lint results
- Updating packages
- Added esling onfig
- Run the prettier command per lint
- Cleaned up the format of the time zone lists
- Fixed icon
- Adding required elements in order to submit
- Fully working now, including preferences and dates
- saving before deletions
- Working with arbitrary dates
- Working with vastly expanded list of timezones
- Working, but needs improvements
- Generally working, but not pasting results
- Initial check-in with code from Claude
- Initial commit
@raycastbot raycastbot added the new extension Label for PRs with new extensions label Jan 5, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Jan 5, 2025

Congratulations on your new Raycast extension! 🚀

You can expect an initial review within five business days.

Once the PR is approved and merged, the extension will be available on our Store.

@alexj
Copy link
Contributor Author

alexj commented Jan 5, 2025

sounds good

Copy link
Contributor Author

@alexj alexj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed file name to pass checks

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LHi 👋

Thanks for your contribution 💪

I have now tested your extension, and I have some feedback ready for you:

  • Should Malagawork too? It doesn't

  • Maybe give the user possible to both copy/paste the output?

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@pernielsentikaer pernielsentikaer self-assigned this Jan 14, 2025
@alexj
Copy link
Contributor Author

alexj commented Jan 18, 2025

Hi @pernielsentikaer , thanks for reviewing it. I've added Malaga and a few additional Spanish cities. I did my best to capture a large swath of populace cities around the world, but I expect I'll continue to add more as I get feedback like yours.

I like your idea about adding the ability to choose between copy/paste. I need to take some time to think about how I'd implement that, with associated preferences, then add the code. In the meantime, can you please review again, and if all is good, approve this so it can go into the store and be used? I'm excited to get it out there!

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 0e0cc08 into raycast:main Jan 19, 2025
2 checks passed
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/alex_jones/time-converter

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@alexj
Copy link
Contributor Author

alexj commented Jan 19, 2025

Hi 👋

Looks good to me, approved 🔥

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants