-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time-converter extension #16183
Add time-converter extension #16183
Conversation
- Merge pull request raycast#1 from alexj/Retrying - Ready to publish - Fully working and passing the lint tests - Readded typescript checking for ESLint - Tweaks to fix lint results - Updating packages - Added esling onfig - Run the prettier command per lint - Cleaned up the format of the time zone lists - Fixed icon - Adding required elements in order to submit - Fully working now, including preferences and dates - saving before deletions - Working with arbitrary dates - Working with vastly expanded list of timezones - Working, but needs improvements - Generally working, but not pasting results - Initial check-in with code from Claude - Initial commit
Congratulations on your new Raycast extension! 🚀 You can expect an initial review within five business days. Once the PR is approved and merged, the extension will be available on our Store. |
sounds good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed file name to pass checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LHi 👋
Thanks for your contribution 💪
I have now tested your extension, and I have some feedback ready for you:
-
Should
Malaga
work too? It doesn't -
Maybe give the user possible to both copy/paste the output?
I'm looking forward to testing this extension again 🔥
Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.
Hi @pernielsentikaer , thanks for reviewing it. I've added Malaga and a few additional Spanish cities. I did my best to capture a large swath of populace cities around the world, but I expect I'll continue to add more as I get feedback like yours. I like your idea about adding the ability to choose between copy/paste. I need to take some time to think about how I'd implement that, with associated preferences, then add the code. In the meantime, can you please review again, and if all is good, approve this so it can go into the store and be used? I'm excited to get it out there! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋
Looks good to me, approved 🔥
Published to the Raycast Store: |
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Awesome, thank you! |
Description
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder