Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iTerm capability to ssh-manager #2084

Merged
merged 6 commits into from
Jun 28, 2022
Merged

Add iTerm capability to ssh-manager #2084

merged 6 commits into from
Jun 28, 2022

Conversation

AaronDavidSchneider
Copy link
Contributor

Description

This PR aims to bring iTerm to the ssh-manager extension.

Applescript bases on this one:
https://github.com/raycast/script-commands/blob/master/commands/apps/iterm/iterm-run-shell-command.applescript

Closes #2005

Screencast

Screen Shot 2022-06-25 at 10 06 29

Checklist

@raycastbot raycastbot added the extension fix / improvement Label for PRs with extension's fix improvements label Jun 25, 2022
@raycastbot
Copy link
Collaborator

raycastbot commented Jun 25, 2022

Thank you for your contribution! 🎉

🔔 @scopsy you might want to have a look.

@AaronDavidSchneider
Copy link
Contributor Author

AaronDavidSchneider commented Jun 25, 2022

I am going to fix the linter issue later today.
Edit: Done

@AaronDavidSchneider
Copy link
Contributor Author

Could you test @wglassly?

@pernielsentikaer
Copy link
Collaborator

Hi @scopsy 👋

Can you give it a spin and approve? 🙂

@scopsy
Copy link
Contributor

scopsy commented Jun 28, 2022

Looks Great! @pernielsentikaer , awesome work @AaronDavidSchneider !

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 🔥 Thanks for your contribution 💪

@pernielsentikaer pernielsentikaer merged commit a0e0a3e into raycast:main Jun 28, 2022
@AaronDavidSchneider AaronDavidSchneider deleted the iterm-ssh branch June 28, 2022 13:50
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/dimagrossman/ssh-manager

@wglassly
Copy link

wglassly commented Jul 4, 2022

Could you test @wglassly?

Good Job! It works well while the iTerm2 front tab is the local one. When the remote tab is fronted, an error occurs.
image

@AaronDavidSchneider
Copy link
Contributor Author

AaronDavidSchneider commented Jul 4, 2022

Could you test @wglassly?

Good Job! It works well while the iTerm2 front tab is the local one. When the remote tab is fronted, an error occurs. image

The issue you are facing is that you are then trying to ssh to some destination from a remote computer.
It just uses your remote session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SSH Connection Manager] Add iTerms Supports
5 participants