Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iPerf Speed Test to dashboards #926

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Conversation

Samywamy10
Copy link
Contributor

Description

This adds a new Dashboard-type script command which runs an iPerf network speed test to a nominated iPerf server. Useful for seeing how quickly file transfers are to something like a NAS (to test local network speed) or to a remote iPerf server (to test internet speed).

This is an inline output and tells you how fast the speed was (on average) in Mbits/sec as well as the time the test was ran.

Type of change

  • New script command

Screenshot

Screen.Recording.2024-04-08.at.11.53.21.pm.mov

Dependencies / Requirements

  1. Install iPerf (brew install iperf)
  2. Add IP address of targeted iPerf server

Checklist

Copy link
Collaborator

@unnamedd unnamedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sam, 👋
thanks for you contribution. Please, give a read on my comments and re-request a review when you finish to address them.

commands/dashboards/iperf-speed-test.sh Outdated Show resolved Hide resolved
commands/dashboards/iperf-speed-test.sh Outdated Show resolved Hide resolved
commands/dashboards/iperf-speed-test.sh Outdated Show resolved Hide resolved
commands/dashboards/iperf-speed-test.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our guidelines, you need to rename this file to include .template in it, for example: iperf-speed-test.template.sh.

Copy link
Contributor Author

@Samywamy10 Samywamy10 Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read that, but then I saw other files that don't use this naming convention so wasn't sure

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File that demands an extra configuration without .template in the name is a mistake, we are going to fix it, thanks for sharing it though.

@Samywamy10 Samywamy10 requested a review from unnamedd April 8, 2024 23:32
Copy link
Collaborator

@unnamedd unnamedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! Thanks for the contribution @Samywamy10!

@unnamedd unnamedd added the accepted PR is ready to be merged label Apr 9, 2024
@dehesa dehesa merged commit f132baa into raycast:master Apr 11, 2024
hyperfocus1337 pushed a commit to hyperfocus1337/script-commands that referenced this pull request Aug 6, 2024
* Add iPerf Speed Test to dashboards

* Add suggestions from unnamedd

Co-authored-by: Thiago Holanda <unnamedd@gmail.com>

* Rename iperf-speed-test.sh to iperf-speed-test.template.sh

---------

Co-authored-by: Thiago Holanda <unnamedd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants