Buffer.write is deprecated. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer.write(string, encoding, offset, length) is deprecated. Use write(string[, offset[, length]][, encoding]) instead.
|
Please can we implement this soon as we will be deploying to servers and need the main repository to be correct |
|
Would be great to have a new release with this addition. |
|
+1 |
activebiz
pushed a commit
to activebiz/Mu
that referenced
this pull request
May 22, 2016
activebiz
pushed a commit
to activebiz/Mu
that referenced
this pull request
May 22, 2016
|
👍 |
1 similar comment
|
👍 |
|
Hey all. As you can tell I don't actively maintain this project anymore, and don't keep up with node much. I will go through the PRs now to get things in a stable state, but if someone is willing to pick up this project please reach out! |
|
Oh, and thanks for the patience here and for the PR, very much appreciated! |
This was referenced Jun 3, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer.write(string, encoding, offset, length) is deprecated. Use write(string[, offset[, length]][, encoding]) instead.
Since offset default value is
0and encoding default value isutf-8, there's no need to pass these arguments.