Merge pull request #1125 from cuviper/ci-success

ci: Use a single action to collect final status

.github/workflows/ci.yaml

@@ -109,16 +109,17 @@ jobs:
           components: rustfmt
       - run: cargo fmt --all --check
 
-  ci-success:
-    name: Complete
+  # One job that "summarizes" the success state of this pipeline. This can then be added to branch
+  # protection, rather than having to add each job separately.
+  success:
+    name: Success
     runs-on: ubuntu-latest
     needs: [check, test, demo, i686, wasm, wasi, fmt]
+    # Github branch protection is exceedingly silly and treats "jobs skipped because a dependency
+    # failed" as success. So we have to do some contortions to ensure the job fails if any of its
+    # dependencies fails.
+    if: always() # make sure this is never "skipped"
     steps:
-      - run: exit 0
-  ci-failed:
-    name: Complete
-    runs-on: ubuntu-latest
-    needs: [check, test, demo, i686, wasm, wasi, fmt]
-    if: failure()
-    steps:
-      - run: exit 1
+      # Manually check the status of all dependencies. `if: failure()` does not work.
+      - name: check if any dependency failed
+        run: jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}'

.github/workflows/pr.yaml

@@ -37,16 +37,17 @@ jobs:
           components: rustfmt
       - run: cargo fmt --all --check
 
-  ci-success:
-    name: Complete
+  # One job that "summarizes" the success state of this pipeline. This can then be added to branch
+  # protection, rather than having to add each job separately.
+  success:
+    name: Success
     runs-on: ubuntu-latest
     needs: [check, test, fmt]
+    # Github branch protection is exceedingly silly and treats "jobs skipped because a dependency
+    # failed" as success. So we have to do some contortions to ensure the job fails if any of its
+    # dependencies fails.
+    if: always() # make sure this is never "skipped"
     steps:
-      - run: exit 0
-  ci-failed:
-    name: Complete
-    runs-on: ubuntu-latest
-    needs: [check, test, fmt]
-    if: failure()
-    steps:
-      - run: exit 1
+      # Manually check the status of all dependencies. `if: failure()` does not work.
+      - name: check if any dependency failed
+        run: jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}'