Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rayon-core/tests/stack_overflow_crash.rs #1009

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Improve rayon-core/tests/stack_overflow_crash.rs #1009

merged 1 commit into from
Jan 17, 2023

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jan 17, 2023

  • Rewrite it within the regular test harness, so it doesn't crash in
    arg-parsing on broad cargo test -- filter commands.
  • Use std::hint::black_box so the test even works in --release.

@cuviper
Improve rayon-core/tests/stack_overflow_crash.rs
e4ba8d1 
- Rewrite it within the regular test harness, so it doesn't crash in
  arg-parsing on broad `cargo test -- filter` commands.
- Use `std::hint::black_box` so the test even works in `--release`.
@cuviper cuviper mentioned this pull request Jan 17, 2023
Closed
3 tasks
@cuviper cuviper linked an issue Jan 17, 2023 that may be closed by this pull request
Test failures on Fedora #585
Closed
3 tasks
@cuviper
Copy link
Member Author

cuviper commented Jan 17, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 17, 2023

Build succeeded:

@bors bors bot merged commit 0cc5912 into rayon-rs:master Jan 17, 2023
@cuviper cuviper deleted the test-stack-overflow branch February 25, 2023 17:58
@cuviper cuviper mentioned this pull request Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failures on Fedora
1 participant
@cuviper