Add const_length function to ParallelIterator #1195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #1189.
As discussed there, this adds a new function to
ParallelIterator
:const_length
which can return a value if the length of aParallelIterator
can be known statically.This function has a default implementation which returns
None
by default, so this is not a breaking change.This change improves the speed of the algorithm in #1189 by a factor of ~2.5 and peak memory usage by about a factor of ~15x. benchmark.
The footgun of splitting unconditionally (which is the main reason the speedup is not that high), is not fixed by this PR though.