-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise the min version requirement because of the ?
operator
#412
Conversation
I updated the readme to 1.13 |
1f499bc
to
c8e6ece
Compare
c8e6ece
to
63938d6
Compare
Yeah, so I should probably not have merged that PR that used (I know that @cuviper and I have differing points of view on this matter, however, as I tend to view the minimum version requirement as more of a courtesy than a hard semver requirement, so I'd like to get his take.) |
Which one was that? AFAICS the only problem here is actually in futures, where 0.1.15 uses But this highlights my real gripe, that such updated requirements are viral, and there's no tooling to deal with it. Any crate that tries to maintain compatibility is at the mercy of its dependencies to do the same. I'll be less grumpy about it when cargo learns how to ignore too-new crates, e.g. RFC 1953.
That would be rust-1.18, which is a big jump to me. And IMO |
You are correct. I grepped the rayon code and it contains no Imho the futures crate has about the same age as 1.12 and does not guarantee any compatibility with older compilers. Sure one could ask @alexcrichton to yank From my point of view it boils down to the questions
For my projects, I check the debian repo where the current stable release is 1.14.0 |
I would highly discourage dependencies like |
We don't really know what compiler folks may be stuck with, and that's part of the problem. The 2017 survey showed most respondents with the current version through rustup, but there were still a tail of people behind, even "1.10 or older". I wouldn't suggest that futures should yank 0.1.15. I just wish that their compatibility choice wasn't so viral. And I also agree that pinning an older version in rayon has its own problems. I suggest just stepping down the version in the CI scripts for now. |
#436 separated rayon-futures, so now we don't need to bump the min version for rayon. |
I fixed the tests for the latest nightly compiler in #411 but since the
?
operator is in the main code the minimal required version must be raised.TODO