Use wrapping addition for JEC #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's make sure the new CI target works: bors try |
|
bors try |
tryAlready running a review |
|
bors try- |
|
bors try |
|
Just tested on the software mentioned in #797 and this has fixed it. |
|
OK, I'll go ahead and publish rayon-core 1.8.1. bors r+ |
|
Published! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
32-bit targets only have 12 bits in the atomic counters to represent the Jobs Event Counter (JEC). This should be fine with wrapping addition, but commit a0efb4a changed from wrapping
fetch_addto a plain+, which is a checked addition in debug builds. We simply need to make this an explicitwrapping_addinstead.In theory, 64-bit targets had a problem too, but 44 bits for JEC is pretty good headroom in debug mode.
Fixes #797.