Rename autocfg probe method to _foo to avoid dead code warning #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is fine, although I must say I'm generally not a fan of bors r+ |
bors bot
added a commit
that referenced
this pull request
May 12, 2022
933: Rename autocfg probe method to _foo to avoid dead code warning r=cuviper a=danielframpton If rayon is built in a configuration with warnings as error (e.g., `RUSTFLAGS=-Dwarnings`), then the probe will fail even though the compiler does have the necessary const generic support. Co-authored-by: Daniel Frampton <Daniel.Frampton@microsoft.com>
|
Build failed: |
|
The failure is not your fault -- I'm looking into what changed on nightly... |
|
That should be fixed by #935. bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If rayon is built in a configuration with warnings as error (e.g.,
RUSTFLAGS=-Dwarnings), then the probe will fail even though the compiler does have the necessary const generic support.