Have GuiTextBox/GuiTextBoxMulti respect BORDER_WIDTH #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuiTextBox and GuiTextBoxMulti's focused and pressed state respect the BORDER_WIDTH style setting, however in normal state this was hard coded to 1. This change now allows users control over the borders when in a normal state.
|
@shadeops Thanks for the review! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to control the BORDER_WIDTH of the text boxes (GuiTextBox and GuiTextBoxMulti) via GuiSetStyle.
Currently, the BORDER_WIDTH of the text boxes is taken into account when in the 'focused' or 'pressed' state. In the 'normal' state this is hard coded to 1. This change replaces the hard coded value and instead does a GuiGetStyle lookup.
By being able to control the TextBox's border we can achieve effects like -
However currently with the value hard coded to 1 you get this -
If this change is counter to Raygui's design or intent please feel free to close.
Thanks for your time.