[MODELS] Fix crash with some GLTF models #2867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a buffer is read using cgltf_load_buffer_base64, the data is a raw void*, so we can't call
cgltf_free
.cgltf_free
assumes the data is acgltf_data
structure and will try to free the various buffers in that structure.This causes a crash with some files (attached)
house.zip
This PR calls a normal free for the data, so it's properly deallocated so it won't crash.
I could not find a pure free method in cgltf, so I just called raylib's free since it looks like that is what is installed for cgltf's allocators anyway.