Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gif recordering doesn't work if num/caps lock is active. #3230

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

mohad12211
Copy link
Contributor

@mohad12211 mohad12211 commented Aug 7, 2023

  • current behavior is to check if only the ctrl modifier is active, the result is that gif recording will not work if num or caps lock are active, which seems like a bug to me.
  • note: this fix allows other modifiers to be set at the same time (ctrl+shift+f12 will also trigger gif recording).
    I don't consider this as a problem, but if you want I can explicitly remove the caps/num lock bits and after that check if mods is equal to GLFW_MOD_CONTROL

@raysan5 raysan5 merged commit db55bed into raysan5:master Aug 7, 2023
@raysan5
Copy link
Owner

raysan5 commented Aug 7, 2023

@mohad12211 Good catch! Actually I didn't considered that possibility... the proposed review looks ok to me. Keep in mind that this functionality was just added for convenience for my students, anyone willing a more solid GIF recording mechanism should implement it manually on user code.

@mohad12211
Copy link
Contributor Author

true! but it's a very good primitive solution for quick recording.

@mohad12211 mohad12211 deleted the glfw_mod_fix branch August 7, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants