Fix compilation for PLATFORM_WEB #3328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raysan5
reviewed
Sep 20, 2023
| @@ -308,13 +308,14 @@ int main(void) | |||
| { | |||
| // Initialization | |||
| //-------------------------------------------------------------------------------------- | |||
| #if defined( PLATFORM_WEB ) | |||
There was a problem hiding this comment.
It can probably be removed, it shouldn't be here.
ghost
closed this
|
@raysan5 Sorry. I synced my repo and ended up messing this PR. I will resend it shortly. |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR changes
PLATFORM_WEB(R201).#include "GLFW/glfw3.h"(R204) is necessary forCoreData'sGLFWwindow *handle;(R282) onPLATFORM_WEB.EM_ASM_INTfromcore_input_gestures_webexample (R311-R318). Doing this so it doesn't block compiling theexamples/core. I'll come back and review this specific example later.Current PLATFORM_WEB status
raylibexamples/audioexamples/coreexamples/modelsexamples/othersexamples/shadersexamples/shapesexamples/textexamples/texturesNotes
examples/othershas some very singular/specific examples. I'll review them last.Environment
emscripten/emsdkon Linux (Mint 21.1 64-bit).Edit 1: added line marks.
Edit 2: added
core_input_gestures_web exampletemporary fix; added current web status, environment and notes; formatting.