Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use System SDL2 As Failsafe #3602

Closed
wants to merge 1 commit into from
Closed

Use System SDL2 As Failsafe #3602

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 4, 2023

Attempt #2, but correctly solving it this time! (Until SDL3, where you don't have to worry about this, because they decided to then do it like every other library ever)

The code works, I tested (except the SDL_LIBRARY_PATH but should just work the same).
On Windows this doesn't do anything because I don't know if shell works the same there.

Other than that, if there are issues with the code/looks bad, tell me.

@Peter0x44
Copy link
Contributor

What's the purpose of the shell if statement?

@raysan5
Copy link
Owner

raysan5 commented Dec 4, 2023

@mr-sihc Sorry, I can't see the need for those additions. It adds a considerable level of complexity to the Makefile to support a specific use case.

@raysan5 raysan5 closed this Dec 4, 2023
@ghost
Copy link
Author

ghost commented Dec 5, 2023

@mr-sihc Sorry, I can't see the need for those additions. It adds a considerable level of complexity to the Makefile to support a specific use case.

it's not actually very specific, SDL is not built standard and anyone who wants to, has to clone it in seperatley, or change the dir

i even put in a comment that says exactly what it does its like 6 lines come on

What's the purpose of the shell if statement?

to check if the SDL_... path is not there, so to activate the failsafe

@ghost ghost deleted the patch-3 branch December 5, 2023 18:50
@Peter0x44
Copy link
Contributor

@mr-sihc I wouldn't bother checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants