[build] Fix Zig raygui build when using addRaygui externally #4027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When addRaygui is used from an external build, for example in a bindings project, the build of a generated `raygui.c` fails with "raylib.h not found" error from the compiler. I've traced this down to a raylib step not adding its `src/` to the shared list of include paths using `addIncludePath` but relying on `addCSourceFiles` `.root` to provide the implicit include path for raylib proper's own files. If raygui is later added to the step the compiler won't know where to look for `raylib.h` and friends and will fail to build. This change simply adds raylib's `src/` to the include path list.
raysan5
changed the title
|
@okvik I'm afraid I'm not an expert on Zig build system, someone with more experience than me should review this PR |
|
Looks good to me |
|
Seems good to me too |
|
Doesn't addRaygui() add the raygui dep's own src folder as an include path? |
|
It does, but raylib.h isn't in there |
Sorry, brain fade. I get it now. 👍 |
Not-Nik
approved these changes
Jun 15, 2024
|
@okvik Thanks for the improvement! @Not-Nik @Gamer-Kold @star-tek-mb @colinwilcox thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
addRayguiis used from an external build, for example in a bindings project, the build of a generatedraygui.cfails with "raylib.h not found" error from the compiler.I've traced this down to a raylib step not adding its
src/to the shared list of include paths usingaddIncludePathbut relying onaddCSourceFiles.rootto provide the implicit include path for raylib proper's own files.If raygui is later added to the step the compiler won't know where to look for
raylib.hand friends and will fail to build.This change simply adds raylib's
src/to the include path list.