Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rlgl] Complements the #4348 GPU skinning fix #4352

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

asdqwe
Copy link
Contributor

@asdqwe asdqwe commented Sep 30, 2024

Rationale: although it may not get defined in config.h#L124-L132, it ends up always getting defined on rlgl.h#L350-L355 defaults, which is more noticeable when using rlgl standalone.

CC @JeffM2501 for review.

@raysan5 raysan5 merged commit 282d647 into raysan5:master Oct 1, 2024
14 checks passed
@raysan5
Copy link
Owner

raysan5 commented Oct 1, 2024

@asdqwe Thanks for the improvement!

Actually, I'm considering exposing a new config flag for RL_SUPPORT_MESH_GPU_SKINNING.

@asdqwe asdqwe deleted the complements-gpu-skinning-fix branch October 1, 2024 11:59
@asdqwe
Copy link
Contributor Author

asdqwe commented Oct 1, 2024

@raysan5 That would be super helpful, specially for 2D oriented builds that wouldn't use GPU skinning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants