[utils] fix const warning with SaveFileText callback #4938
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SaveFileTextCallback does not take it's second argument as a const char*, this is not the same as the argument the caller passes in in SaveFileText function, this generates a warning in gcc.
This PR changes the callback signature to match. This should not change binary compatibility since const is not used at runtime. The argument should be const as the callback can not modify the text it is supposed to save.