Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): sort plan features #502

Merged
merged 2 commits into from
Feb 19, 2024
Merged

feat(sdk): sort plan features #502

merged 2 commits into from
Feb 19, 2024

Conversation

rsbh
Copy link
Member

@rsbh rsbh commented Feb 19, 2024

This PR will sort the features list in plans list screen.
the features which are available on more plans will be on top.
This PR will also fix the Invalid Date issue in invoice list component where no effective_at is available for draft invoice.

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview Feb 19, 2024 5:38am

@rsbh rsbh enabled auto-merge (squash) February 19, 2024 05:38
@rsbh rsbh requested review from pyadav and anujk14 February 19, 2024 05:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7955103468

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.634%

Totals Coverage Status
Change from base Build 7951059485: 0.0%
Covered Lines: 5987
Relevant Lines: 14734

💛 - Coveralls

Copy link
Contributor

@anujk14 anujk14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsbh rsbh merged commit 9133e2e into main Feb 19, 2024
6 checks passed
@rsbh rsbh deleted the feat_sdk_sort_plan_features branch February 19, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants