fix: parse allowed_account_types in provider config
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snorlacs
reviewed
Dec 13, 2021
| if p.Config.Appeal.AllowActiveAccessExtensionIn == "" { | ||
| return ErrAppealFoundActiveAccess | ||
| } | ||
| if p.Config.Appeal != nil { |
There was a problem hiding this comment.
@rahmatrhd what is the expected behaviour if p.Config.Appeal is nil
There was a problem hiding this comment.
guardian will ignore the appeal config, because rules like AllowActiveAccessExtensionIn and AllowPermanentAccess are not present
snorlacs
approved these changes
Dec 13, 2021
lifosmin
referenced
this pull request
in lifosmin/guardian
Aug 31, 2023
rahmatrhd
added a commit
that referenced
this pull request
Nov 15, 2023
* feat(grant): add unique index for active grants * test(grant): cleanup grants table after each test in grant repository test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #89
proto changes: raystack/proton#74