feat: implement replay feature without backup and validation #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauliksoneji
force-pushed
the
DBTCH-1024
branch
2 times, most recently
from
4549dbc to
05dd697
Compare
kushsharma
reviewed
Jun 22, 2021
mauliksoneji
force-pushed
the
DBTCH-1024
branch
5 times, most recently
from
31b9b43 to
6cb3706
Compare
Pull Request Test Coverage Report for Build 985870115
💛 - Coveralls |
mauliksoneji
force-pushed
the
DBTCH-1024
branch
3 times, most recently
from
623f0cf to
d7f3627
Compare
kushsharma
requested changes
Jun 29, 2021
mauliksoneji
force-pushed
the
DBTCH-1024
branch
2 times, most recently
from
02d85dd to
b76c2e1
Compare
kushsharma
requested changes
Jun 30, 2021
job/replay_worker_test.go
Outdated
| assert.Equal(t, errMessage, err.Error()) | ||
| }) | ||
| t.Run("should throw an error when scheduler throws an error", func(t *testing.T) { | ||
| logger.Init(logger.ERROR) |
There was a problem hiding this comment.
We can do this at the top of the test file with InitWithWriter and write could be ioutil.Discard
kushsharma
approved these changes
Jun 30, 2021
kushsharma
reviewed
Jun 30, 2021
kushsharma
reviewed
Jun 30, 2021
kushsharma
requested changes
Jun 30, 2021
job/replay_worker_test.go
Outdated
| assert.Equal(t, errMessage, err.Error()) | ||
| }) | ||
| t.Run("should throw an error when scheduler throws an error", func(t *testing.T) { | ||
| logger.Init(logger.ERROR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.