Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : config airflow BaseOperator #290

Merged
merged 5 commits into from
Apr 18, 2022
Merged

Conversation

irainia
Copy link
Member

@irainia irainia commented Apr 14, 2022

This PR is to address issue mentioned here #263 .

Changes

  • add Airflow under metadata to allow the user to put config related to pool and queue.

Example

...
dependencies: []
hooks: []
metadata:
  ...
  airflow:
    pool: poolA
    queue: queueA

Fix

  • fix error message when encountered deployment failure

Note

In order for this PR to be merged, the following has to be done:

  • merge PR in Proton required by this PR

@coveralls
Copy link

coveralls commented Apr 14, 2022

Pull Request Test Coverage Report for Build 2182658283

  • 24 of 36 (66.67%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 75.112%

Changes Missing Coverage Covered Lines Changed/Added Lines %
store/local/job_spec_adapter.go 10 14 71.43%
api/handler/v1beta1/adapter.go 10 18 55.56%
Totals Coverage Status
Change from base Build 2165523692: -0.05%
Covered Lines: 6027
Relevant Lines: 8024

💛 - Coveralls

@sravankorumilli sravankorumilli requested a review from sbchaos April 14, 2022 06:16
@irainia irainia force-pushed the feat-config-airflow-baseoperator branch from 84be95b to dd118f8 Compare April 14, 2022 06:34
@irainia
Copy link
Member Author

irainia commented Apr 18, 2022

@sravankorumilli , I've tested this in my local, and so far no issue is found and the configuration is passed and used. Please check this if there's any concern or issue.

@irainia irainia merged commit 62bc51c into main Apr 18, 2022
@irainia irainia deleted the feat-config-airflow-baseoperator branch April 18, 2022 06:54
@sravankorumilli
Copy link
Contributor

sravankorumilli commented Jul 7, 2022

fixes #263

@sravankorumilli sravankorumilli changed the title Feat config airflow BaseOperator feat : config airflow BaseOperator Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a mechanism to configure airflow task configurations like pool, queue.
3 participants