Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(optimus): update misconfigured api path for runtime_service.proto #26

Merged
merged 1 commit into from
Sep 8, 2021
Merged

refactor(optimus): update misconfigured api path for runtime_service.proto #26

merged 1 commit into from
Sep 8, 2021

Conversation

scortier
Copy link
Member

@scortier scortier commented Aug 24, 2021 •
edited
Loading

Description

For Optimus :

  1. Updated the misconfigured api path
  2. Adding host entry with the default port in which server starts.

@rohilsurana
Copy link
Member

rohilsurana commented Aug 31, 2021 •
edited
Loading

Looks like the previous import path is available for compilation, but the one in new change isn't.

@rohilsurana
Copy link
Member

@scortier rebased it from main.

@scortier scortier marked this pull request as draft September 6, 2021 11:27
@scortier scortier marked this pull request as ready for review September 6, 2021 18:44
@scortier scortier requested a review from kushsharma September 6, 2021 18:44
@kushsharma kushsharma merged commit a0dd139 into raystack:main Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravisuhag ravisuhag ravisuhag left review comments

@rohilsurana rohilsurana rohilsurana left review comments

@kushsharma kushsharma Awaiting requested review from kushsharma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scortier @rohilsurana @ravisuhag @kushsharma