fix: added filters to list resource api #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishanarya0
changed the title
rahmatrhd
approved these changes
Oct 7, 2021
ravisuhag
pushed a commit
that referenced
this pull request
Nov 10, 2021
* add: add guardian proto * fix: fix java outer classname * fix: change go package name * docs: add descriptive comments on each entity * fix: rename MakeAction to UpdateApproval * fix: change labels type to map<string, string> * fix: add service suffix in the service name * fix: change resources field under provider config to repeated type * fix: change provider create and update request to receive provider config * fix: change update resource return value to be UpdateResourceResponse * fix: change http request bodies to be backward compatible * fix: change update approval http request body * feat: add filter by statuses in list approvals * feat: add reason payload in revoke appeal * feat: add revoke information in appeal * fix: rename RoleConfig to Role Co-authored-by: Ishan Arya <ishanarya0@gmail.com> * feat: add list roles api Co-authored-by: Ishan Arya <ishanarya0@gmail.com> * feat: add list user appeals method * feat: add list user approvals method * feat: add details to each resource of an appeal * feat: add duration to appeal options * feat: add GetProvider * feat: add GetPolicy * feat: add GetResource * feat: remove (soft) resources from db for deleted actual resources in the provider (#46) * feat: added soft delete of resource feature * fix: use is_deleted as a query string Co-authored-by: Ishan Arya <ishanarya0@gmail.com> Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com> * feat: added filters to list resource api (#48) * feat(guardian): add proto messages for additional appeals * feat(guardian): rename appeal user to account_id * feat(guardian): add account_type and created_by * fix(guardian): update approval step message fields * fix(guardian): add creator value in appeal * feat(guardian): add details filter in ListResourcesRequest * feat(guardian): add iam config field in policy * fix(guardian): move guardian proto under v1 * fix(guardian): use proper response message types for Get* rpcs * fix(guardian): remove openapi external docs * chore: change version to v1beta1 * chore: add /v1beta1 prefix in url path Co-authored-by: Ishan Arya <ishanarya0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes w.r.t. this PR: raystack/guardian#61