feat(optimus): support multiple namespaces on replay and backup #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arinda-arif
force-pushed
the
optimus-replay-backup-multiple-namespace
branch
3 times, most recently
from
d79397c to
8f4aa9a
Compare
…wnstream for replay
…ckup dry run response
…es to BackupResponse
arinda-arif
force-pushed
the
optimus-replay-backup-multiple-namespace
branch
from
8f4aa9a to
e51a370
Compare
kushsharma
changed the title
kushsharma
reviewed
Dec 10, 2021
…am and allowed_downstream in replay and backup
arinda-arif
force-pushed
the
optimus-replay-backup-multiple-namespace
branch
from
e30ef93 to
5b28d20
Compare
kushsharma
reviewed
Dec 13, 2021
odpf/optimus/runtime_service.proto
Outdated
| @@ -773,11 +778,13 @@ message BackupDryRunRequest { | |||
| string resource_name = 3; | |||
| string namespace = 4; | |||
| string description = 5; | |||
| bool ignore_downstream = 6; | |||
| bool ignore_downstream = 6 [deprecated=true]; | |||
| repeated string allowed_downstream = 7; | |||
There was a problem hiding this comment.
what if we rename it to downstream_namespace_filter? Also add some comments about how this work?
There was a problem hiding this comment.
sure i can add the comment. for the name, does the concern of naming it allowed_downstream is because it is not clear enough that it is representing namespaces? if yes, does allowed_downstream_namespace sounds better than downstream_namespace_filter? to avoid questions on what is this filter, why it is needed.
There was a problem hiding this comment.
as discussed, will go with allowed_downstream_namespaces
There was a problem hiding this comment.
hi @kushsharma , have changed to allowed_downstream_namespaces and added the comments. please take a look.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.