feat: add resource configuration for job #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushsharma
reviewed
Dec 13, 2021
odpf/optimus/runtime_service.proto
Outdated
Comment on lines
258
to
266
| message JobSpecResourceConfig { | ||
| string cpu = 1; | ||
| string memory = 2; | ||
| } | ||
|
|
||
| message JobSpecResource { | ||
| JobSpecResourceConfig request = 1; | ||
| JobSpecResourceConfig limit = 2; | ||
| } |
There was a problem hiding this comment.
Should we prefix them with Metadata? Resource is a term already used for something else in Optimus. It doesn't directly convey the message these are execution time resource limits/requests
There was a problem hiding this comment.
Oh right. Then, are JobSpecMetadataResource and JobSpecMetadataResourceConfig good enough?
There was a problem hiding this comment.
it's updated as suggested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There's a requirement to allow resource configuration in job for Optimus. It is mentioned in Optimus issue.
Changes
The change is only to add additional message, using it inside the job spec.