Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(guardian): use uuid as identifier instead of uint #89

Merged
merged 1 commit into from
Jan 19, 2022
Merged

fix(guardian): use uuid as identifier instead of uint #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions odpf/guardian/v1beta1/guardian.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ message ListProvidersResponse {
}

message GetProviderRequest {
uint32 id = 1;
string id = 1;
}

message GetProviderResponse {
Expand All @@ -176,7 +176,7 @@ message CreateProviderResponse {
}

message UpdateProviderRequest {
uint32 id = 1;
string id = 1;
ProviderConfig config = 2;
}

Expand All @@ -185,7 +185,7 @@ message UpdateProviderResponse {
}

message ListRolesRequest {
uint32 id = 1;
string id = 1;
string resource_type = 2;
}

Expand Down Expand Up @@ -240,15 +240,15 @@ message ListResourcesResponse {
}

message GetResourceRequest {
uint32 id = 1;
string id = 1;
}

message GetResourceResponse {
Resource resource = 1;
}

message UpdateResourceRequest {
uint32 id = 1;
string id = 1;
Resource resource = 2;
}

Expand Down Expand Up @@ -286,23 +286,23 @@ message ListAppealsResponse {
}

message GetAppealRequest {
uint32 id = 1;
string id = 1;
}

message GetAppealResponse {
Appeal appeal = 1;
}

message CancelAppealRequest {
uint32 id = 1;
string id = 1;
}

message CancelAppealResponse {
Appeal appeal = 1;
}

message RevokeAppealRequest {
uint32 id = 1;
string id = 1;

message Reason {
string reason = 1;
Expand All @@ -318,7 +318,7 @@ message CreateAppealRequest {
string account_id = 1;

message Resource {
uint32 id = 1;
string id = 1;
string role = 2;
google.protobuf.Struct options = 3;
google.protobuf.Struct details = 4;
Expand Down Expand Up @@ -351,7 +351,7 @@ message ListApprovalsResponse {
}

message UpdateApprovalRequest {
uint32 id = 1;
string id = 1;
string approval_name = 2;

message Action {
Expand Down Expand Up @@ -400,7 +400,7 @@ message ProviderConfig {

// Provider contains information about external data provider such as BigQuery, Metabase, etc., credentials, policy, and allowed roles
message Provider {
uint32 id = 1;
string id = 1;
string type = 2;
string urn = 3;

Expand Down Expand Up @@ -457,7 +457,7 @@ message Policy {
string provider_urn = 2;
string type = 3;
string urn = 4;
uint32 id = 5;
string id = 5;
}
ResourceIdentifier resource = 1;
string role = 2;
Expand All @@ -483,8 +483,8 @@ message AppealOptions {

// Appeal is created by user to get access to one or more resources
message Appeal {
uint32 id = 1;
uint32 resource_id = 2;
string id = 1;
string resource_id = 2;
string policy_id = 3;
uint32 policy_version = 4;
string status = 5;
Expand Down Expand Up @@ -512,9 +512,9 @@ message Appeal {

// Approval is an approval item that generated in an appeal based on the selected policy
message Approval {
uint32 id = 1;
string id = 1;
string name = 2;
uint32 appeal_id = 3;
string appeal_id = 3;
string status = 4;
string actor = 5;
string policy_id = 6;
Expand All @@ -528,7 +528,7 @@ message Approval {

// Resource contains information of resource from providers
message Resource {
uint32 id = 1;
string id = 1;
string provider_type = 2;
string provider_urn = 3;
string type = 4;
Expand Down