refactor: abstract configs as a domain level object

app/config.go

@@ -7,26 +7,11 @@ import (
 	"github.com/mitchellh/mapstructure"
 	"github.com/spf13/viper"
 	"strings"
+	"github.com/odpf/siren/domain"
 )
 
-// DBConfig contains the database configuration
-type DBConfig struct {
-	Host     string `mapstructure:"host"`
-	User     string `mapstructure:"user"`
-	Password string `mapstructure:"password"`
-	Name     string `mapstructure:"name" default:"postgres"`
-	Port     string `mapstructure:"port" default:"5432"`
-	SslMode  string `mapstructure:"sslmode"`
-}
-
-// Config contains the application configuration
-type Config struct {
-	Port int      `mapstructure:"port" default:"8080"`
-	DB   DBConfig `mapstructure:"db"`
-}
-
 // LoadConfig returns application configuration
-func LoadConfig() *Config {
+func LoadConfig() *domain.Config {
 	viper.SetConfigName("config")
 	viper.AddConfigPath("./")
 	viper.AddConfigPath("../")
@@ -43,7 +28,7 @@ func LoadConfig() *Config {
 		}
 	}
 
-	err, configKeys := getFlattenedStructKeys(Config{})
+	err, configKeys := getFlattenedStructKeys(domain.Config{})
 	if err != nil {
 		panic(err)
 	}
@@ -56,7 +41,7 @@ func LoadConfig() *Config {
 		}
 	}
 
-	var config Config
+	var config domain.Config
 	defaults.SetDefaults(&config)
 
 	err = viper.Unmarshal(&config)
@@ -66,7 +51,7 @@ func LoadConfig() *Config {
 	return &config
 }
 
-func getFlattenedStructKeys(config Config) (error, []string) {
+func getFlattenedStructKeys(config domain.Config) (error, []string) {
 	var structMap map[string]interface{}
 	err := mapstructure.Decode(config, &structMap)
 	if err != nil {

app/server.go

@@ -2,6 +2,7 @@ package app
 
 import (
 	"fmt"
+	"github.com/odpf/siren/domain"
 	"log"
 	"net/http"
 
@@ -10,15 +11,8 @@ import (
 )
 
 // RunServer runs the application server
-func RunServer(c *Config) error {
-	db, err := store.New(&store.Config{
-		Host:     c.DB.Host,
-		User:     c.DB.User,
-		Password: c.DB.Password,
-		Name:     c.DB.Name,
-		Port:     c.DB.Port,
-		SslMode:  c.DB.SslMode,
-	})
+func RunServer(c *domain.Config) error {
+	db, err := store.New(&c.DB)
 	if err != nil {
 		return err
 	}

domain/provider.go

@@ -0,0 +1,17 @@
+package domain
+
+// DBConfig contains the database configuration
+type DBConfig struct {
+	Host     string `mapstructure:"host"`
+	User     string `mapstructure:"user"`
+	Password string `mapstructure:"password"`
+	Name     string `mapstructure:"name" default:"postgres"`
+	Port     string `mapstructure:"port" default:"5432"`
+	SslMode  string `mapstructure:"sslmode"`
+}
+
+// Config contains the application configuration
+type Config struct {
+	Port int      `mapstructure:"port" default:"8080"`
+	DB   DBConfig `mapstructure:"db"`
+}

store/store.go

@@ -2,24 +2,15 @@ package store
 
 import (
 	"fmt"
+	"github.com/odpf/siren/domain"
 	"log"
 
 	"gorm.io/driver/postgres"
 	"gorm.io/gorm"
 )
 
-// Config for database connection
-type Config struct {
-	Host     string
-	User     string
-	Password string
-	Name     string
-	Port     string
-	SslMode  string
-}
-
 // New returns the database instance
-func New(c *Config) (*gorm.DB, error) {
+func New(c *domain.DBConfig) (*gorm.DB, error) {
 	dsn := fmt.Sprintf(
 		"host=%s user=%s dbname=%s password=%s port=%s sslmode=%s",
 		c.Host,