Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: improve client config cli and rearrange cmd #123

Merged
merged 2 commits into from
Sep 12, 2022
Merged

feat!: improve client config cli and rearrange cmd #123

merged 2 commits into from
Sep 12, 2022

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Sep 9, 2022 •
edited
Loading

This correlates with changes in salt

@mabdh mabdh force-pushed the cli-config-improvement branch from 763b5ee to 007cff7 Compare September 9, 2022 03:54
@coveralls
Copy link

coveralls commented Sep 9, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3037226015

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.638%
Totals Coverage Status
Change from base Build 3036448057: 0.0%
Covered Lines: 2296
Relevant Lines: 2452
💛 - Coveralls

@mabdh mabdh force-pushed the cli-config-improvement branch from 007cff7 to a0ec32e Compare September 9, 2022 04:05
@mabdh mabdh mentioned this pull request Sep 9, 2022
Merged
@mabdh mabdh force-pushed the cli-config-improvement branch from a0ec32e to e3bfdd9 Compare September 9, 2022 04:09
@mabdh mabdh requested review from ravisuhag and rahmatrhd September 9, 2022 04:13
@mabdh mabdh marked this pull request as ready for review September 9, 2022 04:13
@mabdh mabdh requested a review from ravisuhag September 12, 2022 02:52
ravisuhag
ravisuhag reviewed Sep 12, 2022
View reviewed changes
config/config.yaml Outdated Show resolved Hide resolved
@mabdh mabdh force-pushed the cli-config-improvement branch from f6d33b4 to 7167fdf Compare September 12, 2022 08:42
@mabdh mabdh requested a review from ravisuhag September 12, 2022 09:12
@ravisuhag
Copy link
Member

@mabdh can you resolve the conflicts on this?

@mabdh mabdh force-pushed the cli-config-improvement branch from 7167fdf to cfd6ecd Compare September 12, 2022 11:11
@mabdh mabdh linked an issue Sep 12, 2022 that may be closed by this pull request
Improve client and server cli #126
Closed
@ravisuhag ravisuhag merged commit ba1020a into main Sep 12, 2022
@ravisuhag ravisuhag deleted the cli-config-improvement branch September 12, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd

@ravisuhag ravisuhag Awaiting requested review from ravisuhag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve client and server cli
3 participants
@mabdh @coveralls @ravisuhag