Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use salt mux server and update logging to support google cloud logging #124

Merged
merged 8 commits into from
Sep 13, 2022
Merged

refactor: use salt mux server and update logging to support google cloud logging #124

merged 8 commits into from
Sep 13, 2022

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Sep 9, 2022 •
edited
Loading

  • Refactor server to use salt/mux
  • Add google cloud logging support for zap logger
  • Update grpc interceptor logger to use the main zap logger

@coveralls
Copy link

coveralls commented Sep 9, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3037798213

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 93.633%
Totals Coverage Status
Change from base Build 3037521411: -0.005%
Covered Lines: 2294
Relevant Lines: 2450
💛 - Coveralls

@mabdh mabdh linked an issue Sep 9, 2022 that may be closed by this pull request
Use salt/mux for server multiplexing #125
Closed
@mabdh mabdh marked this pull request as ready for review September 9, 2022 14:14
@mabdh mabdh requested review from ravisuhag and rahmatrhd September 9, 2022 14:15
@ravisuhag ravisuhag merged commit 618ea01 into main Sep 13, 2022
@ravisuhag ravisuhag deleted the refactor-server branch September 13, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravisuhag ravisuhag Awaiting requested review from ravisuhag

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use salt/mux for server multiplexing
3 participants
@mabdh @coveralls @ravisuhag