Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alert): send alert groups as a notification #165

Merged
merged 2 commits into from
Jan 16, 2023
Merged

fix(alert): send alert groups as a notification #165

merged 2 commits into from
Jan 16, 2023

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Jan 16, 2023 •
edited
Loading

  • send alert group as a single notification instead of sending multiple notifications for each alert

@coveralls
Copy link

coveralls commented Jan 16, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3928964139

  • 39 of 88 (44.32%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 77.238%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/store/postgres/alerts.go 4 5 80.0%
core/notification/service.go 0 2 0.0%
plugins/providers/cortex/alert.go 0 2 0.0%
plugins/providers/cortex/service.go 0 5 0.0%
core/template/mapper.go 14 29 48.28%
internal/api/v1beta1/alert.go 17 41 41.46%
Files with Coverage Reduction New Missed Lines %
internal/api/v1beta1/alert.go 1 71.31%
Totals Coverage Status
Change from base Build 3900617604: -0.2%
Covered Lines: 2942
Relevant Lines: 3809
💛 - Coveralls

@mabdh mabdh linked an issue Jan 16, 2023 that may be closed by this pull request
Sending alerts group as a notification #166
Closed
@mabdh mabdh merged commit 54a02a3 into main Jan 16, 2023
@mabdh mabdh deleted the alerts-grouping branch January 16, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohilsurana rohilsurana rohilsurana approved these changes

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sending alerts group as a notification
3 participants
@mabdh @coveralls @rohilsurana