Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add silencing notification #167

Merged
merged 3 commits into from
Feb 1, 2023
Merged

feat: add silencing notification #167

merged 3 commits into from
Feb 1, 2023

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Jan 20, 2023

proto PR is here raystack/proton#237

  • add silences feature
  • add some new tables to support silences feature
  • refactor notification service
  • refactor post alerts api
  • refactor post notification receiver api

@coveralls
Copy link

coveralls commented Jan 20, 2023

Pull Request Test Coverage Report for Build 4060590481

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 614 of 790 (77.72%) changed or added relevant lines in 26 files are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 77.1%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/notification/notification.go 21 22 95.45%
internal/api/v1beta1/alert.go 12 13 92.31%
internal/store/postgres/subscription.go 3 6 50.0%
core/notification/dispatch_subscriber_service.go 107 111 96.4%
core/silence/silence.go 37 41 90.24%
internal/api/v1beta1/silence.go 62 66 93.94%
internal/store/postgres/alerts.go 9 13 69.23%
core/notification/service.go 46 51 90.2%
plugins/providers/cortex/service.go 0 5 0.0%
core/silence/type.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
core/notification/notification.go 1 91.67%
plugins/queues/postgresq/queue.go 2 72.62%
core/notification/service.go 3 82.29%
plugins/queues/inmemory/queue.go 6 49.12%
Totals Coverage Status
Change from base Build 3929358348: -0.1%
Covered Lines: 3360
Relevant Lines: 4358

💛 - Coveralls

@mabdh mabdh marked this pull request as ready for review January 24, 2023 15:07
@mabdh mabdh merged commit 1c7ed68 into main Feb 1, 2023
@mabdh mabdh deleted the silences branch February 1, 2023 09:45
mabdh added a commit that referenced this pull request Feb 2, 2023
mabdh added a commit that referenced this pull request Feb 2, 2023
* Revert "feat: add silencing notification (#167)"

This reverts commit 1c7ed68.

* fix(rule): revert silence and fix bug in rules api
@mabdh mabdh restored the silences branch February 3, 2023 02:54
@mabdh mabdh linked an issue Feb 3, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alerts & Notification Silencing
3 participants