Feat/alerting #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbheda
force-pushed
the
feat/alerting
branch
from
6c272f4 to
b34accf
Compare
working yaml file add route to update alerting credentials call alertmanager to sync config end to end alertmanager sync add request validations for alert credentials
kevinbheda
force-pushed
the
feat/alerting
branch
from
b34accf to
98c1e75
Compare
templates/service_test.go
Outdated
| @@ -130,7 +131,7 @@ func TestService_Upsert(t *testing.T) { | |||
| result, err := dummyService.Upsert(dummyTemplate) | |||
| assert.EqualError(t, err, "name cannot be empty") | |||
| assert.Nil(t, result) | |||
| repositoryMock.AssertNotCalled(t, "Upsert") | |||
| repositoryMock.AssertNotCalled(t, "UpsertSlack") | |||
There was a problem hiding this comment.
Looks like this change was not required inside the templates package.
kevinbheda
force-pushed
the
feat/alerting
branch
from
200788a to
23a4d4f
Compare
|
@kevinbheda @rohilsurana Please squash the fix ci commits when merging. |
configure postgres connection string based on password
kevinbheda
force-pushed
the
feat/alerting
branch
from
574589b to
d8af118
Compare
rohilsurana
reviewed
Mar 22, 2021
ravisuhag
pushed a commit
that referenced
this pull request
Aug 21, 2022
feat: alert credentials api to sync configs to alertmanager
ravisuhag
pushed a commit
that referenced
this pull request
Aug 21, 2022
feat: alert credentials api to sync configs to alertmanager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.