feat: add grpc support #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Abhishek <abhi.sah.97@gmail.com>
Co-authored-by: Praveen Yadav <pyadav9678@gmail.com>
Co-authored-by: Abhishek <abhi.sah.97@gmail.com>
Co-authored-by: Abhishek <abhi.sah.97@gmail.com>
…utes Co-authored-by: Abhishek <abhi.sah.97@gmail.com>
Co-authored-by: Abhishek <abhi.sah.97@gmail.com>
Co-authored-by: Abhishek <abhi.sah.97@gmail.com>
Co-authored-by: Praveen Yadav <pyadav9678@gmail.com>
Co-authored-by: Praveen Yadav <pyadav9678@gmail.com>
…nvalid parameters Co-authored-by: Praveen Yadav <pyadav9678@gmail.com>
Co-authored-by: Praveen Yadav <pyadav9678@gmail.com>
ravisuhag
reviewed
Aug 26, 2021
ravisuhag
reviewed
Aug 26, 2021
Makefile
Outdated
| generate-proto: ## regenerate protos | ||
| @echo " > cloning protobuf from odpf/proton" | ||
| @echo " > generating protobuf" | ||
| @buf generate --template buf.gen.yaml https://github.com/odpf/proton.git --path odpf/odin |
There was a problem hiding this comment.
@whoAbhishekSah Generation path is wrong. Also, would recommend to use git commit ref id in buf generate command.
There was a problem hiding this comment.
path is fixed.
Didn't see any reference using git commit ref. Even if it is possible would you like to ref with merged commit hash or last commit reference pushed into the branch 🤔
Co-authored-by: Abhishek <abhi.sah.97@gmail.com>
Co-authored-by: Abhishek <abhi.sah.97@gmail.com>
Closed
ravisuhag
pushed a commit
that referenced
this pull request
Aug 21, 2022
* feat: add grpc gateway support Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * feat: create grpc handlers for alert history APIs Co-authored-by: Praveen Yadav <pyadav9678@gmail.com> * create grpc handlers for workspace list API * create grpc handlers for exchange code API * create grpc handlers for alert credentials APIs * feat: create grpc handlers for notification API Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * feat: create grpc handlers for rules APIs Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * feat: create grpc handlers for template APIs and remove associated routes Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * test: create alert history api * refactor: request & response payload from camelCase to snake_case Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * feat: add slack blocks in send slack notification grpc api Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * docs: serve swagger docs via http api * refactor: remove redundant logging config & add missing log statements Co-authored-by: Praveen Yadav <pyadav9678@gmail.com> * feat: add newrelic integration for grpc handlers Co-authored-by: Praveen Yadav <pyadav9678@gmail.com> * fix: return success response when create alert history fails due to invalid parameters Co-authored-by: Praveen Yadav <pyadav9678@gmail.com> * refactor: fix linting and formatting issues Co-authored-by: Praveen Yadav <pyadav9678@gmail.com> * refactor: follow grpc naming conventions Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * fix: change buf generate path to siren Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * fix: add siren executable in gitignore * refactor: change Alerts to singular word Alert Co-authored-by: Praveen Yadav <pyadav9678@gmail.com>
ravisuhag
pushed a commit
that referenced
this pull request
Aug 21, 2022
* feat: add grpc gateway support Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * feat: create grpc handlers for alert history APIs Co-authored-by: Praveen Yadav <pyadav9678@gmail.com> * create grpc handlers for workspace list API * create grpc handlers for exchange code API * create grpc handlers for alert credentials APIs * feat: create grpc handlers for notification API Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * feat: create grpc handlers for rules APIs Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * feat: create grpc handlers for template APIs and remove associated routes Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * test: create alert history api * refactor: request & response payload from camelCase to snake_case Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * feat: add slack blocks in send slack notification grpc api Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * docs: serve swagger docs via http api * refactor: remove redundant logging config & add missing log statements Co-authored-by: Praveen Yadav <pyadav9678@gmail.com> * feat: add newrelic integration for grpc handlers Co-authored-by: Praveen Yadav <pyadav9678@gmail.com> * fix: return success response when create alert history fails due to invalid parameters Co-authored-by: Praveen Yadav <pyadav9678@gmail.com> * refactor: fix linting and formatting issues Co-authored-by: Praveen Yadav <pyadav9678@gmail.com> * refactor: follow grpc naming conventions Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * fix: change buf generate path to siren Co-authored-by: Abhishek <abhi.sah.97@gmail.com> * fix: add siren executable in gitignore * refactor: change Alerts to singular word Alert Co-authored-by: Praveen Yadav <pyadav9678@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for both HTTP and GRPC endpoints. The HTTP endpoints are reverse proxied to GRPC ones via grpc-gateway package.