Extra functionnalities

[AgP42]

Proposal to stop the update timer on following cases :

• no user is present in front of the Mirror. Detection made by using a PIR sensor and with the module MMM-PIR-Sensor, that send the notification "USER_PRESENCE"
• the module is hidden (by a carousel for example). To do so the core function "suspend"/"resume" are used
  When both "USER_PRESENCE" = True and the module is displayed, then all instance of MMM-PublicTransportHafas are updated immediatelly and the update time relaunched (on the value definied by the user or default value)

In case none of this modules are presents or only one of both, there is no impact on the behaviour.

[derhuerst]

I don't know about the technical details of this, or too much about magic mirrors, but this would reduce traffic on the VBB API by a lot!

[rudibarani]

I would support merging this, too. Good idea to use the USER_PRESENCE notification to disable API calls when no-one is present. And if no notification is sent, the module will function as usual.

[KristjanESPERANTO]

I've looked at all forks and merged them into my own [1].

This is not an attempt to take over maintenance for this module, because I still hope that @raywo will be active again. But at the moment it should make more sense to use my fork, because it contains several improvements and newer modules.

[1] https://github.com/KristjanESPERANTO/MMM-PublicTransportHafas

[rudibarani]

I've looked at all forks and merged them into my own [1].

This is not an attempt to take over maintenance for this module, because I still hope that @raywo will be active again. But at the moment it should make more sense to use my fork, because it contains several improvements and newer modules.

[1] https://github.com/KristjanESPERANTO/MMM-PublicTransportHafas

Thanks a lot!
I have just tried to install your fork and got an error when running "npm install":

25 verbose cwd /Users/phillip/MagicMirror/modules/MMM-PublicTransportHafas
26 verbose Darwin 15.6.0
27 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "install"
28 verbose node v12.16.1
29 verbose npm  v7.6.3
30 error code EJSONPARSE
31 error path /Users/phillip/MagicMirror/modules/MMM-PublicTransportHafas/package.json
32 error JSON.parse Unexpected string in JSON at position 362 while parsing '{
32 error JSON.parse   "name": "MMM-PublicTransportHafas",
32 error JSON.parse '
33 error JSON.parse Failed to parse JSON data.
33 error JSON.parse Note: package.json must be actual JSON, not just JavaScript.
34 verbose exit 1

[derhuerst]

@rudibarani There's a missing comma in @KristjanESPERANTO's fork:

KristjanESPERANTO@c447ea9#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R13

[KristjanESPERANTO]

Thanks @rudibarani and @derhuerst. I added the comma.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information