Fixing duplicate roles in filter bug

rayykim · Aug 8, 2016 · 68e7df3 · 68e7df3
1 parent eb6546e
commit 68e7df3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/kolibri/plugins/management/assets/src/actions.js b/kolibri/plugins/management/assets/src/actions.js
@@ -165,8 +165,6 @@ function showUserPage(store) {
     const users = responses[1];
     const roles = responses[2];
 
-    console.log(id, users, roles)
-;
     store.dispatch('SET_FACILITY', id[0]); // for mvp, we assume only one facility exists
     store.dispatch('SET_ROLES', roles);
     store.dispatch('ADD_USERS', users);

diff --git a/kolibri/plugins/management/assets/src/state/store.js b/kolibri/plugins/management/assets/src/state/store.js
@@ -57,7 +57,16 @@ const mutations = {
   },
 
   SET_ROLES(state, roles) {
-    state.roles = roles;
+    // used to efficiently check for dupes
+    const uniqueRoles = {};
+    // returns array with removed duplicates
+    state.roles = roles.filter(role => {
+      if (uniqueRoles.hasOwnProperty(role)) {
+        return false;
+      }
+
+      return (uniqueRoles[role] = true);
+    });
   },
 };