Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use cloned krms for user impersonation #178

Merged
merged 4 commits into from
Apr 15, 2021
Merged

fix: use cloned krms for user impersonation #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7066e2
fix: return a cloned krm from the cache
alewitt2 Apr 15, 2021
81f71cb
fix: krm must be defined
alewitt2 Apr 15, 2021
8c377f9
fix: clone main razee krm for each event
alewitt2 Apr 15, 2021
6076865
remove comments
alewitt2 Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/EventHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ module.exports = class EventHandler {
this._logger = params.logger || require('../bunyan-api').createLogger('EventHandler');

if (!(this._kubeResourceMeta &&
this._kubeResourceMeta.constructor &&
this._kubeResourceMeta.constructor.name === 'KubeResourceMeta' &&
this._kubeResourceMeta.hasVerb('watch'))) {
this._kubeResourceMeta.constructor &&
this._kubeResourceMeta.constructor.name === 'KubeResourceMeta' &&
this._kubeResourceMeta.hasVerb('watch'))) {
throw Error('Resource does not support verb "watch"');
}
if (!this._kc) {
Expand Down Expand Up @@ -68,7 +68,7 @@ module.exports = class EventHandler {
// Event Handler
async eventHandler(data) {
let params = {
kubeResourceMeta: this._kubeResourceMeta,
kubeResourceMeta: this._kubeResourceMeta.clone(),
eventData: data,
kubeClass: this._kc,
logger: this._logger,
Expand Down
4 changes: 4 additions & 0 deletions lib/KubeResourceMeta.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ module.exports = class KubeResourceMeta {
this._logger = require('./bunyan-api').createLogger('KubeResourceMeta');
}

clone() {
return new KubeResourceMeta(this._path, this._resourceMeta, this._kubeApiConfig);
}

uri(options = {}) {
let result = `${this._path}`;
if (options.watch) {
Expand Down
2 changes: 1 addition & 1 deletion lib/kubeClass.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ module.exports = class KubeClass {
if (verb && krm && !krm.hasVerb(verb)) {
krm = undefined;
}
return krm;
return krm !== undefined ? krm.clone() : krm;
}

};