fix: Use Rotated Service Account Auth Token #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow kube class base options to be generated as needed instead of at construction time, this allows us to get a fresh auth token to kube api in case the one we got at instantiation went stale.
must add kubeApiConfig to watchman constructor in order to pass watchUri validation check on instantiation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
alewitt2
added
enhancement
needs to be added for each call to Watchman `watch()` to ensure new values are fetched each time.
carrolp
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starting in Kube 1.22, service account tokens are mounted as projected volumes on pods, and those tokens are rotated on a regular interval. For the time being the old tokens are marked as stale, but still valid. At some point in the future, the old tokens will no longer be valid. This PR should update our controllers to re-fetch the token at a regular interval to ensure we always use a valid token when talking to the kube api.
refs:
expires